Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] New posts counter doesn't have enough space #207

Closed
K1rakishou opened this issue Jul 20, 2019 · 4 comments · Fixed by #212
Closed

[BUG] New posts counter doesn't have enough space #207

K1rakishou opened this issue Jul 20, 2019 · 4 comments · Fixed by #212
Labels
bug Something isn't working

Comments

@K1rakishou
Copy link

Should be easy to fix by just adding more space for it. I have changed it because of the new icon but didn't expect that it may take this much space.

1563604917938

@K1rakishou K1rakishou added the bug Something isn't working label Jul 20, 2019
@Astridchan
Copy link

Somewhat related: it looks like the font of the bookmarked threads in the sidebar got smaller too, could that be restored back to its old size?

@K1rakishou
Copy link
Author

K1rakishou commented Jul 20, 2019

Yes I made it smaller because otherwise with both icons visible there will be almost no space left for the thread title. I've also shifted the icon a little bit to the left. There is just almost no free space left. If someone can make a good design for this screen when both icons are visible (there is actually a third one that shows up when a thread gets archived) then I will be happy to implement it.

@Astridchan
Copy link

Couldn't the downloading icon just take 0 space until you actually start downloading and when you do start downloading just cut the thread title with "..." as already happens with long thread titles to make space for the downloading icon? Also, the downloading icon is kinda big, you could probably make that smaller.

@K1rakishou
Copy link
Author

K1rakishou commented Jul 20, 2019

Couldn't the downloading icon just take 0 space until you actually start downloading and when you do start downloading just cut the thread title with "..." as already happens with long thread titles to make space for the downloading icon?

Well it already works like this right now. But still with the old font size there is little space left for the thread title. The pin list should be refactored anyway (so that you can group pins by site/board and shit) so I think we can leave this issue until then. But yeah, I guess I could make the icon a little bit smaller.

K1rakishou added a commit that referenced this issue Jul 20, 2019
…w-posts-counter' into (#207)-reserve-more-space-for-new-posts-counter
Adamantcheese added a commit that referenced this issue Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants