Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hostname error, utf-8 encoding #123

Merged
merged 3 commits into from Aug 15, 2022

Conversation

JSpiner
Copy link

@JSpiner JSpiner commented Aug 15, 2022

Summary

  • Fix hostname replacement error
  • Fix korean function name borken error

Description

Fix hostname replacement error

A problem occurs when the local and remote home account names are different.
Because of the quotation marks, the local home name is being assigned.
For example,

// local : /home/smith
// remote : /home/john

$ ssh mainframer "echo '~/mirakle/myproject'"
/home/smith/mirakle/myproject             // <- it happens in 1.5.2 and occurs NotFoundException

$ ssh mainframer "echo ~/mirakle/myproject"
/home/john/mirakle/myproject               // <- this is what we want

So I remove quotes at 779c3a7

Fix korean function name borken error

If I make the function name in Korean, it brokes in the console like below.
스크린샷 2022-08-15 오후 3 24 25
It also happens bash, zsh, IDE terminal.
The test result(*.html, *.xml) is created and downloaded as utf-8, but utf-8 is not applied to the ssh script.
So I append encoding envirnment at 779c3a7.

Related

- Using tlide slash `~` with quotes assigns local home directory. Should use without quotes to assign remote home directory.
- Refactored to make it easier to add or edit.
- Fixed a bug where the Korean test function name was broken.
@Adambl4 Adambl4 merged commit ab471e6 into Adambl4:development Aug 15, 2022
@Adambl4
Copy link
Owner

Adambl4 commented Aug 15, 2022

Looks great, thank you!

@Adambl4
Copy link
Owner

Adambl4 commented Aug 15, 2022

This PR available in io.github.adambl4:mirakle:1.5.3-RC-9

@JSpiner
Copy link
Author

JSpiner commented Aug 24, 2022

Thanks! 🙇 🙇 🙇
Do you have any plans for a stable release version 1.5.3?

@Adambl4
Copy link
Owner

Adambl4 commented Sep 8, 2022

@JSpiner Sorry for the delay, 1.6.0 has just been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants