Update firewall.sh #126
Merged
Update firewall.sh #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This update focus once more on the CDNWhitelisting. Before the CDNWhitelist would be completely deleted from the IPset before downloading the New CDNWhitelisting Entries. The behavior for CDNWhitelisting should be to delete entries only when CDNWhitelisting is disabled. The enabled behavior should only be to remove duplicates if present in newly downloaded CDNwhitelists. This reduces the likelihood of CDNWhitelisting breaking itself as described here in the SNBForums. https://www.snbforums.com/threads/wan-ip-outbound-blocked.85184/post-843884
* remove blank space
* fix the order for removing NVRAM entries on skynet start-up.
dave14305
reviewed
May 26, 2023
* make it portable and functional while deleting possibly expired CDN entries. Satisfy @dave14305 concerns.
|
@Adamm00 I pulled in your changes for v7.4.2, if you decide to add these so it wouldn't conflict with your branch |
* switch "nvram save" to "nvram commit" courtesy of @dave14305 .
|
I fixed the nvram save, which should be nvram commit per @dave14305 suggestion. |
|
Thanks for the pull requests as always. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.snbforums.com/threads/wan-ip-outbound-blocked.85184/post-843884