-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different design: more compact windows and collapsing/closing control on each tab bar #237
base: release-0.14
Are you sure you want to change the base?
Conversation
This should be feature-complete and bug-free AFAIK. |
- Close all tabs: "×" - Collapse all tabs: "▼"
370e477
to
417f665
Compare
Hi, sorry for the massive delay! My irl stuff has been insane in the last couple of months. I think the features you've added are great, although I think having a button that lets you collapse a whole window (which we lost in this PR) would be really nice to have. Can we add it back? I've fixed up a few things following the release of 0.13 and rebasing to the next release branch. Let me know if there's anything I could help you with. |
I'd be glad to add this feature, but I'm not fully certain how this should be designed. Should collapsing a whole window be:
|
@Adanos020 I've implemented this feature like this: Recording.at.2024-07-10.01.04.44.mp4So essentially all features available in the original design is now in the right-click context menu of the relevant buttons. I named this feature minimizing a window, to avoid frequent confusions with collapsing a node in the codebase. Let me know if there's a better way to name this ;) |
@micfong-z This looks good, although it isn't immediately obvious that you can right-click on the buttons. I reckon a tooltip on each button could help with that. |
@Adanos020 Done – I've also fixed cargo test. I reckon another design of activating these features by shift-clicking (or ctrl/alt/...-clicking?) the buttons might be possible, but I'm not really sure *: I just checked the way how egui handles modifier keys. This shouldn't be a problem now. |
That sounds good, I'd say let's come up with a few designs and let the library users choose. One design I've been thinking of is to have separate buttons for windows, but make them look like little bookmarks behind the window (or the tab bar) that'll pull out when you hover over them. How does that sound? |
That design sounds brilliant! Though I would have to dig deep enough to figure out a way to display some sort of floating panels behind windows. AFAIK, since all Edit: could tooltip/menu implementations help? |
Resolves #238. See the issue for a full discussion of this design.
Here's a list of technically missing features in this PR, but I'd like to hear some opinions before carrying on ;)
Proper styling (especially rounding)Leaf
(fd805c9, ccce02f)