feat(deploy): Add workflow to deploy in master #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algreasley
reviewed
Oct 10, 2023
| node-version: 20 | ||
|
|
||
| # URL_SUFFIX is used so we can append branch/<branch-name> to BASE_URL, or leave blank in the case of uat/dev where we do not need it | ||
| - name: Set variables |
There was a problem hiding this comment.
this task not used, can you delete please (can always bring across from RT branch.yml later if we need it
| - name: Verify Quality | ||
| run: yarn verify | ||
|
|
||
| - name: Build (web) |
There was a problem hiding this comment.
minor - can you drop the (web) suffix for these .. RA client build is for both variants (web and openfin)
There was a problem hiding this comment.
although .. this will not work for OpenFin as we have no replacement (currently) for the Docker/nginx/lua parameter substitution that is occurring now in the K8s deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.