Expose Dimensions template paramter for {nd_}range, {nd_,h_}item and id
#1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsfriess
changed the title
Dimensions template paramter for {nd_}range, {nd_,h_}item and id
illuhad
reviewed
Apr 25, 2023
|
I added it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the newest revision of the SYCL 2020 spec, a
static constexpr int dimensionsmember was added to a few classes to expose theirDimensionstemplate parameter. In our case, the template parameter was typically lowercase, so I had to change it toDimensions(with an uppercase D). I also changed it to uppercase in place where it wasn't strictly necessary (for instance in forward declarations) just to make the names of the template parameters consistent.