Allow for non-default-constructible iterators in std::for_each_n
#1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `return_type` When the macro `HIPSYCL_STDPAR_OFFLOAD` is used in `std::for_each_n`, the type `return_type` is `ForwardIt` (in the C++ standard it is called `InputIt`) and this iterator only has to meet the requirements of a `LegacyInputIterator` which does not include default-constructibility. By replacing the if/else with a ternary operator, the declaration that tries to call the default constructor can be removed.
nilsfriess
force-pushed
the
stdpar/defaultconst-forward-it
branch
from
2a6ef3d
to
3df57b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the macro
HIPSYCL_STDPAR_OFFLOADis used instd::for_each_n, the typereturn_typeisForwardIt(in the C++ standard it is calledInputIt) and this iterator only has to meet the requirements of aLegacyInputIteratorwhich does not include default-constructibility. By replacing the if/else with a ternary operator, the declaration that causes a call to the (possibly non-existent) default constructor can be removed.Edit:
I just realised that I accidentally removed a call toFixed it.q.wait()in the second macro; ill fix that asap.