[CI][CBS] Enable LLVM 17 in CI #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the hack doesn't work too reliably, we're using it elsewhere already, and the default is to activate, so that should be fine. Also, we currently only need the hack for LLVM > 16 and LLVM < 18 when targeting HIP in SMCP. The first bad LLVM commit is: 72fc08a The first good-again LLVM commit is: d77c620 The LLVM issue is tracked on: llvm/llvm-project#68120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables LLVM 17 to CI.
HIP SMCP needed a bit of a workaround to fully disable any extra passes landing in the device pipeline from CBS.
(InstCombine triggers some invalid addrspace cast issue)