Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CMake version and CXX standard in examples #1204

Merged

Conversation

Calandracas606
Copy link
Contributor

Explicitly set c++ 17

clang <= 15 will not default to -std=c++17, which may cause IDEs using clangd (CLion) to report errors.

This change will improve developer experience, and provide a more complete "example" of a CMakeLists.txt

Copy link
Collaborator

@illuhad illuhad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illuhad illuhad merged commit eeebfd4 into AdaptiveCpp:develop Oct 23, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants