Fix multi-threaded task processing #739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #728
The main change is that this introduces a mutex to lock
dag_manager::flush_async()
, thereby giving task submission atomic semantics.Task submission involves two main steps:
dag_builder
from all threadsWhen task submission from another thread jumps in between those steps, it can happen it grabs those DAG nodes for processing. In this case, since
flush_async()
did not have atomic semantics, an incorrect submission order can arise.This can lead to nodes, that should have already been submitted, being submitted too late, and the
submit(); flush_sync()
pattern not actually guaranteeing that everything is submitted.This PR fixes this.
Also adds some minor improvements in this area, like improving diagnostic output, and additional debug assertions.