Add HIPSYCL_SYCLCC_EXTRA_COMPILE_OPTIONS #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `HIPSYCL_SYCLCC_EXTRA_ARGS`, but will only be applied to files explicitly listed in `SOURCES` argument of `add_sycl_to_target`.
|
This is good in principle, but we need to come up with another name. It's not really device-only, as it also affects host compilation. Maybe a name to focus on the fact that it affects the SYCL compiler, not linker? |
|
It's setting |
|
I like it! |
al42and
changed the title
acmnpv
pushed a commit
to gromacs/gromacs
that referenced
this pull request
Oct 10, 2022
Requires AdaptiveCpp/AdaptiveCpp#824. Inlining does not affect AMD, but helps tremendously for CUDA. Refs #4588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
HIPSYCL_SYCLCC_EXTRA_ARGS, but will only be applied to files explicitly listed inSOURCESargument ofadd_sycl_to_target.Examples of flags where it can be useful are various
-Wno-...and-ffast-math(which can break some code on host, but can be desired for device kernels).I'm open to changing the name of the variable.
Testing: https://gist.github.com/al42and/2c21e842702f45b9be44d793a77a7d69, there
mkdir build && cmake -DHIPSYCL_TARGETS=omp -Bbuild/ && cmake --build build/