Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hipSYCL clang plugin path on MacOS #883

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Conversation

illuhad
Copy link
Collaborator

@illuhad illuhad commented Nov 30, 2022

@normallytangent Does this help with accelerated CPU on Apple?

@normallytangent
Copy link
Collaborator

Confusingly, it does not. I tested it with accelerated cpu set to On. I get the same error I showed earlier but now if complains it can't find hipSYCL_clang.dylib file even though it is already there at the same path the error message is about.

@illuhad
Copy link
Collaborator Author

illuhad commented Nov 30, 2022

That's weird... Can you please send me the error, or post it somewhere?

bin/syclcc-clang Outdated Show resolved Hide resolved
@fodinabor
Copy link
Collaborator

Uhh, nice! :)

One thing that's slightly related, which I learned in the meantime, and I just wanted to note: the plugin-style dynamic libraries like libhipSYCL_clang.so or libhipSYCL_omp.so usually are (should be) declared with add_library(<name> MODULE <src>).
See https://cmake.org/cmake/help/latest/command/add_library.html and maybe https://stackoverflow.com/questions/4845984/difference-between-modules-and-shared-libraries
Doesn't make much of a functional difference. On MacOS MODULE libraries will be .so files instead of .dylib, though.

Copy link
Collaborator

@normallytangent normallytangent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it once more, all the tests pass with accelerated cpu.

@illuhad illuhad merged commit 2e59709 into develop Dec 1, 2022
@illuhad illuhad deleted the hotix/clang-plugin-macos branch December 1, 2022 14:56
@illuhad illuhad mentioned this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants