Update sycl::vec class to reflect SYCL 2020 requirements
#907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `get_size` member is deprecated and replaced by `byte_size`
According to the spec (Table 144), the method `sycl::vec::as` is supposed to have the signature `template <typename asT> asT as() const`. As can be seen from the return type, the template type `asT` should therefore be the whole vec type, not just the type of its elements.
|
Thanks! Have you made a survey whether we use those deprecated functions somewhere internally in hipSYCL? E.g. I strongly suspect that |
|
No, I didn't really think about that... Actually, there is one function in the group function tests that still uses it but this function isn't actually used anywhere so maybe this function can just be deleted anyway? |
|
@DieGoldeneEnte can you comment on the function in the group function tests? |
illuhad
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following small changes in the
sycl::vecclass to reflect the SYCL 2020 spec:sizemethod is added which replaces theget_countmethod (which is now marked deprecated)byte_sizemethod is added which replaces theget_size(which is now marked deprecated)asmethod is changed: according to Table 144 of the SYCL 2020 spec, the template parameterasTshould refer to the whole vector type that the vec is reinterpreted as. Previously,asTreferred to the type of the new vec's elements.These all came up when trying to compile the CTS
vec_apitest; it is still not compiling, but the remaining errors seem to be be CTS-related, not hipSYCL-related.