[SSCP] Handle llvm.lifetime.start/end intrinsic when moving allocas to different AS #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illuhad
force-pushed
the
feature/sscp-handle-llvm-lifetime-intrinsic
branch
from
e10a7bc
to
b0c0287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm.lifetime.start/endintrinsics don't like when they depend on address space casts. This can however happen in our Address Space Inference pass, which might move alloca instructions to a different address space.Preexisting lifetime intrinsics depending on address space casts can cause a compiler crash.
This PR addresses this by removing such intrinsic calls - this is a hotfix, of course the better solution would be to rewrite such intrinsics to refer to the correct address space.