[SSCP] Do not use OpenMP CXX flags/link line #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, SSCP has used the CXX and linker flags of the OpenMP backend.
This was probably motivated by SSCP running as part of a regular host compilation, and therefore needing similar flags. However, using OpenMP here causes SSCP to pull in flags such as
-fopenmpeven if they are not needed or wanted.Furthermore, since at least the OpenMP sequential backend is activated by
syclccin any case, the necessary flags for host compilation are already there in any case and do not need to be handled by the SSCP flag generator. The current approach just causes superfluous or duplicate host flags to be emitted.