Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing constructor to the buffer class (see the description in the spec here). This constructor allows to construct buffers from containers for which
std::data(container)
andstd::size(container)
are valid, e.g.,std::vector
orstd::array
.As described by the spec,
write_back
is disabled ifstd::data(container)
does return a const pointer, and enabled otherwise. Because of this extra handling, we cannot just delegate to another constructor.