Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IntParticles (int32) #73

Merged
merged 33 commits into from
Nov 8, 2023
Merged

Add IntParticles (int32) #73

merged 33 commits into from
Nov 8, 2023

Conversation

joeljonsson
Copy link
Collaborator

  • add IntParticles to allow additional functionality in the napari viewer, e.g. converting image layers to labels (Note: IntParticles are not supported in most pyapr functionality)
  • add a brief quick start guide with pictures and code snippets to the readme

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3fc6fa) 74.97% compared to head (5a0cc79) 75.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   74.97%   75.24%   +0.26%     
==========================================
  Files          56       56              
  Lines        2442     2460      +18     
==========================================
+ Hits         1831     1851      +20     
+ Misses        611      609       -2     
Files Coverage Δ
pyapr/data_containers/__init__.py 100.00% <ø> (ø)
pyapr/reconstruction/APRSlicer.py 97.53% <100.00%> (+2.79%) ⬆️
pyapr/tests/test_reconstruction.py 100.00% <100.00%> (ø)
pyapr/tests/test_utils.py 100.00% <100.00%> (ø)
pyapr/utils/types.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cheesema cheesema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeljonsson looks good, what brought about the addition on the Int, I just had some questoin regarding the CI configs.

@joeljonsson
Copy link
Collaborator Author

joeljonsson commented Nov 7, 2023

@joeljonsson looks good, what brought about the addition on the Int, I just had some questoin regarding the CI configs.

It's basically just to allow to convert between image and labels layer in napari. It (and many other types) could be added to the processing, but with the way we handle particle types at the moment its just kind of a hassle

@joeljonsson joeljonsson merged commit d516388 into master Nov 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants