IsNullable support for C# 8 nullable reference types #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks :) |
|
Thank you for fixing many bugs of the original Typewriter. Your fork is my go-to version of Typewriter now. :) Would you consider enabling GitHub issues on your fork? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bae691d, you fixed the bug that C# 8 nullable reference types introduced. But, TypeWriter's
IsNullablereturnedfalsefor these types. This pull request changesIsNullableso that it also returnstruefor nullable reference types.Technically, nullable reference types aren't
System.Nullable<>, but instead have[Nullable]attributes that the compiler generates. However, this distinction is not relevant for Typewriter's purposes. Users of Typewriter are likely usingIsNullableto determine if a C# property should be optional (?) in TypeScript, and optional properties in Typescript work for both value types and reference types. So this is why I decided to improve the existingIsNullableimplementation instead of adding something new like "IsNullableReferenceType".