New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed IsDate property for nullable DateTime and DateTimeOffset #32

Merged

AdaskoTheBeAsT merged 1 commit into AdaskoTheBeAsT:master from dintecom:fix-nullable-is-date

Jun 29, 2023

ArtemDintecom commented Jun 28, 2023 •

edited

This fix is needed to make the following code work again:

if (p.Type.IsDate) {
    if (p.Type.IsNullable) {
        ...
    }
}

Also, instead of name, encodeURIComponent(String({name})) will now be generated again for DateTime?.


          Fixed IsDate property for nullable DateTime and DateTimeOffset

3a2c0d6

Owner

AdaskoTheBeAsT commented Jun 29, 2023

hi thanks a lot for finding and fix!
I will release this on weekend

AdaskoTheBeAsT merged commit 91c6c51 into AdaskoTheBeAsT:master

ArtemDintecom deleted the fix-nullable-is-date branch

June 29, 2023 17:42

RudeySH mentioned this pull request

Why was there a breaking change for nullable types? #33

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment