Set postgres to start on boot. #16
Conversation
ghost
self-assigned this
|
This change is |
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @ben-adazza)
images/finatra-postgres/Dockerfile, line 21 at r1 (raw file):
USER postgres RUN service postgresql start &&\ psql --command "CREATE USER adazza WITH SUPERUSER PASSWORD 'adazza';"
I missed whether the reason for the && (vs 2 lines) was in the previous PR .
images/finatra-postgres/Dockerfile, line 26 at r1 (raw file):
USER root RUN update-rc.d postgresql enable
Given that these containers spin up, run some commands, then get destroyed, I am not sure I understand this? Does starting the service not work? Maybe service postgresql start should be run as root.
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @ben-adazza)
a discussion (no related file):
I am guessing this change is because postgres wasn't running
I am testing some of my questions below so feel free to ignore those for now
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @ben-adazza)
images/finatra-postgres/Dockerfile, line 21 at r1 (raw file):
Previously, SpainTrain (Mike S) wrote…
I missed whether the reason for the
&&(vs 2 lines) was in the previous PR .
Just copy pasta from the internet. Making them two lines is ok with me.
images/finatra-postgres/Dockerfile, line 26 at r1 (raw file):
Previously, SpainTrain (Mike S) wrote…
Given that these containers spin up, run some commands, then get destroyed, I am not sure I understand this? Does starting the service not work? Maybe
service postgresql startshould be run as root.
This is so when the container boots postgres is also started on boot.
ghost
force-pushed
the
enable-postgres
branch
from
c71a472
to
9deaf4e
Compare
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @SpainTrain and @ben-adazza)
images/finatra-postgres/Dockerfile, line 21 at r1 (raw file):
Previously, ben-adazza (Ben McNiel) wrote…
Just copy pasta from the internet. Making them two lines is ok with me.
it was good copy pasta, because it is indeed required :-D
There was a problem hiding this comment.
after going back to original revision
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @ben-adazza)
a discussion (no related file):
Sorry for the distracting questions, I should have just done manual testing to understand what was going on. The original revision is good.
ghost
force-pushed
the
enable-postgres
branch
2 times, most recently
from
483eb2b
to
7867ade
Compare
Use more descriptive test user name.
ghost
force-pushed
the
enable-postgres
branch
from
7867ade
to
34d2edd
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3.
Reviewable status: 0 of 1 approvals obtained
Overview
Brief summary
Closes #
Testing