This repository has been archived by the owner on Sep 15, 2020. It is now read-only.
Allow independent setting of font awesome weight #70
Closed
rondale-sc
wants to merge
1
commit into
master
from
allow-independent-setting-of-font-awesome-weight
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -112,3 +112,32 @@ test('tooltip box direction can be modified', async function(assert) { | |
'tooltip box reflects correct direction' | ||
); | ||
}); | ||
|
||
test('tooltip can set iconWeight', async function(assert) { | ||
assert.expect(2); | ||
|
||
this.render(hbs` | ||
{{#adde-tooltip-icon data-test-tooltip-icon=true iconWeight="far"}} | ||
template block text | ||
{{/adde-tooltip-icon}} | ||
`); | ||
|
||
let icon = new IconHelper(); | ||
|
||
assert.ok(icon.isIcon('far'), 'tooltip icon has new class'); | ||
assert.ok(!icon.isIcon('fas'), 'tooltip icon no longer has default class'); | ||
}); | ||
|
||
test('tooltip can set iconWeight defaults to fas', async function(assert) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added this to ensure that we kept existant behavior. When no |
||
assert.expect(1); | ||
|
||
this.render(hbs` | ||
{{#adde-tooltip-icon data-test-tooltip-icon=true}} | ||
template block text | ||
{{/adde-tooltip-icon}} | ||
`); | ||
|
||
let icon = new IconHelper(); | ||
|
||
assert.ok(icon.isIcon('fas'), 'tooltip icon has new class'); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? I think the argument is
iconWeightClass
?