Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Test clicking on snippets links on docs pages #746

Merged
merged 2 commits into from
Jul 29, 2019

Conversation

bantic
Copy link
Member

@bantic bantic commented Jul 29, 2019

I noticed that one of the docs demos on the "Sorting" page was throwing an error when its 'component.js' snippet was clicked.

This adds a test to click all the snippets on all the docs pages, to keep them from going out of sync.

@bantic bantic added the docs label Jul 29, 2019
@bantic bantic force-pushed the bantic/docs/click-snippets-links branch from a5af05e to d202c2b Compare July 29, 2019 17:55
@bantic bantic requested review from mixonic and cyril-sf July 29, 2019 18:19
@bantic
Copy link
Member Author

bantic commented Jul 29, 2019

You can see the issue at the current live deployed docs.

This PR fixes that, and a similar one on the "Sorting" docs page

Copy link
Member

@mixonic mixonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good hunting 👍

@bantic bantic merged commit c9aa88b into master Jul 29, 2019
@bantic bantic deleted the bantic/docs/click-snippets-links branch July 29, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants