Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical scroll indicators #854

Merged
merged 11 commits into from Jan 22, 2021

Conversation

ahmacleod
Copy link
Contributor

@ahmacleod ahmacleod commented Jan 19, 2021

Vertical analogue of #814. Shows horizontal shadows when it is possible to scroll up or down. Respects any header or footer rows.

Extends #853

20210120 Vertical Scroll Indicators

With scrollbars-always-on:
20210122 Vertical Scroll Indicators Scrollbars Always On

Usage:

<EmberTable as |t|>
  <t.head
    @columns={{columns}}
    @scrollIndicators="all"
  />
  <t.body @rows={{rows}} />
</EmberTable>

Possible string values for scrollIndicators are all, horizontal, vertical, and none. Boolean values true and false are aliased to all and none, respectively.

@ahmacleod ahmacleod changed the title [WIP] Vertical scroll indicators Vertical scroll indicators Jan 19, 2021
Copy link
Contributor

@twokul twokul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Could you add a gif to the PR description and maybe a code snippet (copy-paste from the one in the docs)?

@ahmacleod ahmacleod changed the title Vertical scroll indicators [WIP] Vertical scroll indicators Jan 20, 2021
@ahmacleod ahmacleod changed the title [WIP] Vertical scroll indicators Vertical scroll indicators Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants