New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical scroll indicators #854
Merged
ahmacleod
merged 11 commits into
Addepar:3.0-beta
from
ahmacleod:vertical-scroll-indicators
Jan 22, 2021
Merged
Vertical scroll indicators #854
ahmacleod
merged 11 commits into
Addepar:3.0-beta
from
ahmacleod:vertical-scroll-indicators
Jan 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmacleod
changed the title
[WIP] Vertical scroll indicators
Vertical scroll indicators
Jan 19, 2021
twokul
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Could you add a gif to the PR description and maybe a code snippet (copy-paste from the one in the docs)?
ahmacleod
changed the title
Vertical scroll indicators
[WIP] Vertical scroll indicators
Jan 20, 2021
ahmacleod
force-pushed
the
vertical-scroll-indicators
branch
from
January 21, 2021 20:08
cf1da1e
to
3fd8340
Compare
ahmacleod
force-pushed
the
vertical-scroll-indicators
branch
from
January 21, 2021 20:21
3fd8340
to
a9a458b
Compare
ahmacleod
changed the title
[WIP] Vertical scroll indicators
Vertical scroll indicators
Jan 21, 2021
ahmacleod
force-pushed
the
vertical-scroll-indicators
branch
from
January 21, 2021 23:33
cf2fa7a
to
8133ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertical analogue of #814. Shows horizontal shadows when it is possible to scroll up or down. Respects any header or footer rows.
Extends #853
With scrollbars-always-on:
Usage:
Possible string values for
scrollIndicators
areall
,horizontal
,vertical
, andnone
. Boolean valuestrue
andfalse
are aliased toall
andnone
, respectively.