Bump ember-classy-page-object #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
force-pushed
the
mixonic/bump-page-objects
branch
4 times, most recently
from
7de13f7
to
c878ff0
Compare
mixonic
commented
Feb 6, 2021
package.json
Outdated
| @@ -34,7 +34,7 @@ | |||
| "@html-next/vertical-collection": "^1.0.0-beta.14", | |||
| "broccoli-string-replace": "^0.1.2", | |||
| "css-element-queries": "^0.4.0", | |||
| "ember-classy-page-object": "^0.6.1", | |||
| "ember-classy-page-object": "Addepar/ember-classy-page-object#714cb4523f7cbab01e7539b0ddfe7d81714ba919", | |||
There was a problem hiding this comment.
Can't be landed until there is a release here.
just published new version https://github.com/san650/ember-cli-page-object/releases/tag/v1.17.6 |
|
Thank you very much @ro0gr! I appreciate the fast turn around! 😅 You are a champ. |
mixonic
force-pushed
the
mixonic/bump-page-objects
branch
from
a01b16b
to
07f8f68
Compare
Merged
* Update some tests to wrap mutations in runloop so rendering flushes.
mixonic
force-pushed
the
mixonic/bump-page-objects
branch
from
07f8f68
to
30ffbb6
Compare
|
This branch passed an internal smoke test on Addepar's main Ember codebase 👍 I'll land it and cut a release. It should address the deprecation message noted at #831 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump https://github.com/Addepar/ember-classy-page-object which will also result in https://github.com/san650/ember-cli-page-object getting bumped.
TODO:
See if we have a ton of deprecations from ember-cli-page-object nowThere definitely are a bunch of deprecations, but it doesn't seem like we should block this PR on them. Many of them need to be addressed by updating the component integration test suite, which we need to assert can be done with Ember 2.8. IMO we should decouple fixing deprecations from landing the dependency bump.deprecateusage (ohmy)