-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is-last-column and is-slack classes to table cells #876
Conversation
e769542
to
86dccd7
Compare
86dccd7
to
3ed58ca
Compare
3ed58ca
to
492202c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left a few notes ✍️
*/ | ||
contentHeaders: collection('th:not([data-test-ember-table-slack])', Header), | ||
slackHeaders: collection('th[data-test-ember-table-slack]', Header), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming this private API. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. Moved "offline" for a broader discussion.
In this case, contentHeaders
is redundant, unused internally, and new since 3.0. It's probably safe to assume nobody is using it. More clarity would be good here though.
Changes:
is-slack
class to slackth
andtd
elementsis-last-column
class to the rightmost column cells. In slack modes, the rightmost column can be either the slack column (when slack is visible) or its immediate neighbor to the left (when no slack is visible).is-first-column
class