Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce min and max width constraints before initial fill #881

Conversation

ahmacleod
Copy link
Contributor

@ahmacleod ahmacleod commented Mar 16, 2021

Ensures that min and max column widths are enforced on initial render.

Currently, min and max column widths are only enforced in two cases:

  • when the widthConstraint mode is violated
  • when the user manually resizes a column

In particular, if widthConstraint is none, or the chosen widthConstraint is not initially violated (e.g. lte-container when there is only one column), min and max column widths will be ignored on initial render.

@ahmacleod ahmacleod marked this pull request as ready for review March 16, 2021 19:28
Copy link
Contributor

@jiayingxu jiayingxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ahmacleod ahmacleod merged commit eec0594 into master Mar 16, 2021
@ahmacleod ahmacleod deleted the alex.macleod.temp/enforce-min-and-max-constraints-before-initial-fill branch March 16, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants