Detect row count test selector to enable observers #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
force-pushed
the
mixonic/detect-test-selector-for-debug
branch
2 times, most recently
from
8ef0ffb
to
a90cadd
Compare
These observers were installed based on `runInDebug`. As ember-test-selectors uses its own configuable logic for when to strip test selectors, the two systems of "debug" mode can get out of sync. For example, if you build Ember in a "test" environment but with a production Ember.js asset, then `runInDebug` is a no-op despite the test selectors being in place. You may configure Ember CLI this way if you want to ensure your application tests run in a mode similar to production. Swap them to detect the attribute binding presence, which should not be there when ember-test-selectors is stripping selectors/bindings.
mixonic
force-pushed
the
mixonic/detect-test-selector-for-debug
branch
from
a90cadd
to
1e8fddd
Compare
Arijit-Roy
pushed a commit
to xomaczar/ember-table
that referenced
this pull request
Sep 6, 2021
These observers were installed based on `runInDebug`. As ember-test-selectors uses its own configuable logic for when to strip test selectors, the two systems of "debug" mode can get out of sync. For example, if you build Ember in a "test" environment but with a production Ember.js asset, then `runInDebug` is a no-op despite the test selectors being in place. You may configure Ember CLI this way if you want to ensure your application tests run in a mode similar to production. Swap them to detect the attribute binding presence, which should not be there when ember-test-selectors is stripping selectors/bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These observers were installed based on
runInDebug. As ember-test-selectors uses its own configuable logic for when to strip test selectors, the two systems of "debug" mode can get out of sync.For example, if you build Ember in a "test" environment but with a production Ember.js asset, then
runInDebugis a no-op despite the test selectors being in place. You may configure Ember CLI this way if you want to ensure your application tests run in a mode similar to production.Swap them to detect the attribute binding presence, which should not be there when ember-test-selectors is stripping selectors/bindings.