Deprecate Property Fallback Lookup (no implicit this, take two) #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
force-pushed
the
no-implicit-this-2
branch
from
8d0ae95
to
f282c43
Compare
|
I've rebased and force pushed this branch. |
|
@johanrd This looks pretty great! The docs build is failing on what seems like a legit error ( |
|
@mixonic thanks, the |
kpfefferle
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
This was suggested in #897 as a candidate for 4.0, but it's a backwards-compatible change - so I'll go ahead and merge this to master and then rebase the 4.0-beta branch to pick up on these changes since they do help unblock support for Ember 4.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.