Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing peer dependency @babel/core@^7.0.0-0 #910

Merged
merged 1 commit into from Sep 29, 2021

Conversation

bantic
Copy link
Member

@bantic bantic commented Sep 29, 2021

When installing using yarn, there are many console warnings about an unmet peer dependency on @babel/core@^7.0.0-0 for some of the deps, such as @babel/plugin-proposal-object-rest-spread.
These warnings also show up when consumers do their yarn install, e.g.:

warning "ember-table > @babel/plugin-proposal-nullish-coalescing-operator@7.14.5" has unmet peer dependency "@babel/core@^7.0.0-0".

This PR adds an explicit dependency on babel/core to silence those warnings.

Doing a yarn install in ember-table locally before:

image

And after:

image

I am taking inspiration from yarnpkg/yarn#5347 (comment) that recommends that package maintainers add the missing peer dep locally, when the yarn warning originates from their package.

@bantic
Copy link
Member Author

bantic commented Sep 29, 2021

Test failures appear to be due to changes in Ember v4 (which is "beta" at the time CI ran).

@mixonic
Copy link
Member

mixonic commented Sep 29, 2021

I've opened #911 to pin the CI at 3.28, and force pushed a rebase of this branch.

@mixonic mixonic force-pushed the bantic/add-missing-babel-core-dep branch from fa00a61 to 4485be0 Compare September 29, 2021 14:25
@mixonic mixonic merged commit 4ac46e5 into master Sep 29, 2021
@mixonic mixonic deleted the bantic/add-missing-babel-core-dep branch September 29, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants