Bugfix: Avoid IndexError when no video description is present #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin stopped working a few weeks ago on my machine (unable to view 'All Shows'). After some investigation, I noticed that an
IndexError
was being raised fromlistShows()
. This occurs due to the fact that the Vice: Shows page has a show listed without a description:When the regex encounters the empty
<p>
tag, it returns an empty string as the match. When the following line attempts to get the0
index of that empty string, anIndexError
occurs.These changes return a
list
object with an empty string at the0
index when no match is found by regex, thus avoiding theIndexError
.This bug could theoretically occur anywhere where the results of a regex are accessed at index
0
without first scrutinizing the results.ps: I love this plugin! Thanks for putting it up in the first place! (:thumbsup:)