-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for address.js #16
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 1 month ago. 1) iamonuwa has applied to start work (Funders only: approve worker | reject worker). Awesome task, ready to work on this immediately. I understand the requirement very well Learn more on the Gitcoin Issue Details page. 2) thevaleriemack has been approved to start work. read issue and documentation Learn more on the Gitcoin Issue Details page. 3) deamme has applied to start work (Funders only: approve worker | reject worker). Already did the first task :)! I know exactly what to do since I've already contributed a lot to the project! Learn more on the Gitcoin Issue Details page. |
@geleeroyale can you elaborate on this? |
@thevaleriemack Awesome you found us! If you want to take this on, I can increase the bounty (was actually testing a gitcoin I got at devcon) To your question: I did not mean the donation form (which you were referring to), but the main headline and text that is editable only by the AdrrETH owner. (see screenshots below) FYI: We actually just switched to mainnet, pls keep that in mind |
oh wow - gitcoin put 50 dai on this! I see now :) THANKS GITCOIN!!! |
Because @iamonuwa applied first, I will approve him as worker for this! There is lots more to do though @thevaleriemack - I'll put up more issues soon! EDIT: Actually @thevaleriemack was first - sorry its my first time resolving a gitcoin contributor conflict. how is this stuff usually handled? EDIT2: I can not approve anybody because I am not the creator of the bounty |
Cool, no worries! I’m definitely happy to help on other things. Did this
already and it was quick.
…On Fri, Nov 9, 2018 at 9:52 AM geleeroyale ***@***.***> wrote:
Because @iamonuwa <https://github.com/iamonuwa> applied first, I will
approve him as worker for this! There is lots more to do though
@thevaleriemack <https://github.com/thevaleriemack> - I'll put up more
issues soon!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIDeqroDmJepxjYzuZK7ZKRw_WpSpvDyks5utZapgaJpZM4YDEF2>
.
|
Just approved you @thevaleriemack since you've already started on the issue :) |
awesome @thevaleriemack - please pull for latest changes and submit a PR yourself when you feel its ready |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 50.0 DAI (50.0 USD @ $1.0/DAI) has been submitted by: @ceresstation please take a look at the submitted work:
|
Thank you @thevaleriemack and thanks again to @ceresstation for crowdfunding this issue!! |
Had to reopen this issue due to antipattern in solution by @thevaleriemack
as a solution for When editing the form it should be pre-filled with the previous text is not working as expected: 1 - It would prefill the input with prior data but not save that data when confirming (we use onChange to set the State - no input no state change) |
@geleeroyale - Frank from Gitcoin here - have you paid @thevaleriemack out yet? If not, I can override the work submitted status back to "work started" and see if @thevaleriemack has bandwidth to fix the solution. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @thevaleriemack.
|
The text was updated successfully, but these errors were encountered: