Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for address.js #16

Open
2 of 3 tasks
geleeroyale opened this issue Oct 30, 2018 · 14 comments
Open
2 of 3 tasks

Improvements for address.js #16

geleeroyale opened this issue Oct 30, 2018 · 14 comments

Comments

@geleeroyale
Copy link
Contributor

geleeroyale commented Oct 30, 2018

  • Button Go to my Addreth should vanish on own addreth
  • click on "from" address in leaderboard takes you to THAT addresses ADDRETH!!!
  • When editing the form it should be pre-filled with the previous text
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Nov 8, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 month ago.
Please review their action plans below:

1) iamonuwa has applied to start work (Funders only: approve worker | reject worker).

Awesome task, ready to work on this immediately. I understand the requirement very well

Learn more on the Gitcoin Issue Details page.

2) thevaleriemack has been approved to start work.

read issue and documentation
install dependencies
run dev app
make changes
test changes
build
run prod app
fix if necessary
done!

Learn more on the Gitcoin Issue Details page.

3) deamme has applied to start work (Funders only: approve worker | reject worker).

Already did the first task :)! I know exactly what to do since I've already contributed a lot to the project!

Learn more on the Gitcoin Issue Details page.

@v-stickykeys
Copy link
Contributor

  • When editing the form it should be pre-filled with the previous text

@geleeroyale can you elaborate on this?
Do you mean the last eth amount and message the person sent through addreth should remain in the form fields?

@geleeroyale
Copy link
Contributor Author

@thevaleriemack Awesome you found us! If you want to take this on, I can increase the bounty (was actually testing a gitcoin I got at devcon)

To your question: I did not mean the donation form (which you were referring to), but the main headline and text that is editable only by the AdrrETH owner. (see screenshots below)

FYI: We actually just switched to mainnet, pls keep that in mind

1
2

@geleeroyale
Copy link
Contributor Author

oh wow - gitcoin put 50 dai on this! I see now :)

THANKS GITCOIN!!!

@geleeroyale
Copy link
Contributor Author

geleeroyale commented Nov 9, 2018

Because @iamonuwa applied first, I will approve him as worker for this! There is lots more to do though @thevaleriemack - I'll put up more issues soon!

EDIT: Actually @thevaleriemack was first - sorry its my first time resolving a gitcoin contributor conflict. how is this stuff usually handled?

EDIT2: I can not approve anybody because I am not the creator of the bounty

@v-stickykeys
Copy link
Contributor

v-stickykeys commented Nov 9, 2018 via email

@spm32
Copy link

spm32 commented Nov 9, 2018

Just approved you @thevaleriemack since you've already started on the issue :)

@geleeroyale
Copy link
Contributor Author

awesome @thevaleriemack - please pull for latest changes and submit a PR yourself when you feel its ready

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 50.0 DAI (50.0 USD @ $1.0/DAI) has been submitted by:

  1. @thevaleriemack

@ceresstation please take a look at the submitted work:

  • PR by @thevaleriemack

@geleeroyale
Copy link
Contributor Author

Thank you @thevaleriemack and thanks again to @ceresstation for crowdfunding this issue!!

@geleeroyale
Copy link
Contributor Author

Had to reopen this issue due to antipattern in solution by @thevaleriemack

value={titleValue || (ipfsPayload && ipfsPayload.title)}

as a solution for

When editing the form it should be pre-filled with the previous text

is not working as expected:

1 - It would prefill the input with prior data but not save that data when confirming (we use onChange to set the State - no input no state change)
2 - It would refill the prior info when deleting all characters in a form field

@frankchen07
Copy link

@geleeroyale - Frank from Gitcoin here - have you paid @thevaleriemack out yet? If not, I can override the work submitted status back to "work started" and see if @thevaleriemack has bandwidth to fix the solution.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @thevaleriemack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants