Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/linter to Develp #2

Merged
merged 26 commits into from
Jun 26, 2020
Merged

Feature/linter to Develp #2

merged 26 commits into from
Jun 26, 2020

Conversation

AdedayoOpeyemi
Copy link
Owner

NB: I was unable to do much work on the project and I would want to request for a new project. So I can start all over again.

Capstone project

Capstone projects are solo projects at the end of the each of the Microverse Main Technical Curriculum sections. Building this project is very important for you because:

  • It's a real-world-like project, built with business specifications that will look really nice in your portfolio; and
  • You will get feedback about the achievement of technical and soft skills gained during this section of the program.

Project requirements

  • A linter developed in Ruby
  • It's a linter for beginners, i.e., it provides feedback about errors or warning in code little by little
  • You choose the rest of the functionality for the linter
  • The README must include instructions on how to use the linter and examples of good and bad code

Developing the project, you should follow the best practices that you already learned in the previous projects, like setting-up a code linter, using GitFlow, testing your business logic, writing descriptive commit messages and README.

@AdedayoOpeyemi AdedayoOpeyemi force-pushed the feature/linter branch 2 times, most recently from 00c585b to a2091ad Compare June 24, 2020 02:18
@AdedayoOpeyemi
Copy link
Owner Author

Thanks for the feedback.

The requested changes have been implemented.

I had to disable the cop for # rubocop: disable Style/MixinUsage in the spec files. Without doing that github action seems not to be able to reach the modules from when running Rspec test online.

Also, another issue that was raised was for the case where github action was unable to reach ruby gems while performing the check online here until [ -f Gemfile ] && bundle --deployment was deleted

it always throws
LoadError: cannot load such file -- colorize

` run: |

  •     # [ -f Gemfile ] && bundle --deployment
    
  •      [ -f Gemfile ] && bundle
        gem install --no-document rspec:'~>3.0'`
    

I have raised an issue for that, still waiting for feedback.

Thanks

@AdedayoOpeyemi AdedayoOpeyemi merged commit 013780c into develop Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant