Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed All Issue #2

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Conversation

waleedcodes
Copy link
Contributor

Some change in Index.html And app.css

Some change in Index.html And app.css
Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alt-school-assignment-1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 9:16am

@waleedcodes
Copy link
Contributor Author

waleedcodes commented Feb 3, 2024

Fix All Issue Check my Pull Request

@Adedoyin-Emmanuel
Copy link
Owner

Screenshot from 2024-02-03 23-31-39

The inputs aren't aligned properly. Please Fix

@waleedcodes
Copy link
Contributor Author

waleedcodes commented Feb 4, 2024

Now Check the Pull Request

Some change in form
@Adedoyin-Emmanuel
Copy link
Owner

Screenshot from 2024-02-06 04-07-25

The button isn''t aligned with the input elements also on smaller screens, the entire form isn't responsive any longer.

update some changes
@waleedcodes
Copy link
Contributor Author

Fix #1

Screenshot_0
Screenshot_11

@Adedoyin-Emmanuel
Copy link
Owner

It works fine now 😄 . Thanks for contributing. By the way, I've other projects you might be interested in contributing to.

@Adedoyin-Emmanuel Adedoyin-Emmanuel merged commit 54103a2 into Adedoyin-Emmanuel:master Feb 6, 2024
2 checks passed
@waleedcodes
Copy link
Contributor Author

Done !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants