Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why react not peer dependency? #163

Closed
onemanstartup opened this issue Aug 10, 2017 · 2 comments
Closed

Why react not peer dependency? #163

onemanstartup opened this issue Aug 10, 2017 · 2 comments

Comments

@onemanstartup
Copy link

onemanstartup commented Aug 10, 2017 •
edited

It was already merged #55
Why it was reverted?
@ok2ju
Copy link

ok2ju commented Sep 1, 2017

@AdeleD any updates? Because we use your package and we have specific version of react, so in result we get 2 different versions of react.
I think react and react-dom should be peerDependencies

@AdeleD
Copy link
Owner

AdeleD commented Sep 17, 2017

Done

@AdeleD AdeleD closed this as completed Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AdeleD @onemanstartup @ok2ju