Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json should better include react-dom as peer dependency #55

Closed
topgun743 opened this issue Mar 21, 2016 · 2 comments
Closed

package.json should better include react-dom as peer dependency #55

topgun743 opened this issue Mar 21, 2016 · 2 comments

Comments

@topgun743
Copy link

Hi,
You are using react-dom in your package.json file under dependencies. In my opinion this should be better under peer dependencies. If someone is already using React in his project then it may cause weird conflicting issues.
@hkrutzer hkrutzer mentioned this issue Mar 22, 2016
Closed
@vhpoet
Copy link
Contributor

vhpoet commented Mar 24, 2016

Fixed in 400929a

@topgun743
Copy link
Author

Thanks

Get Outlook for Android

On Thu, Mar 24, 2016 at 12:06 PM -0700, "Vahe Hovhannisyan" notifications@github.com wrote:

fixed in 400929a

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@AdeleD AdeleD closed this as completed Mar 26, 2016
@onemanstartup onemanstartup mentioned this issue Aug 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vhpoet @AdeleD @topgun743