fix: set default GPU vendors list (kubeflow/kubeflow#7320)

The change introduced by kubeflow/kubeflow#6736 removed the default GPU vendors list, which causes an issue when trying to select a vendor from the dropdown menu if the vendors list is not configured. This commit can be reverted if proper documentation is provided for users/distributions to configure the dropdown menu. Fixes #7273
Adembc · Jun 22, 2024 · 561d526 · 561d526
1 parent 92cd7ef
commit 561d526
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 14 deletions.
diff --git a/notebooks/crud-web-apps/jupyter/backend/apps/common/yaml/spawner_ui_config.yaml b/notebooks/crud-web-apps/jupyter/backend/apps/common/yaml/spawner_ui_config.yaml
@@ -129,12 +129,11 @@ spawnerFormDefaults:
       # the list of available vendors in the dropdown
       #  `limitsKey` - what will be set as the actual limit
       #  `uiName` - what will be displayed in the dropdown UI
-      vendors: []
-      #vendors:
-      #  - limitsKey: "nvidia.com/gpu"
-      #    uiName: "NVIDIA"
-      #  - limitsKey: "amd.com/gpu"
-      #    uiName: "AMD"
+      vendors:
+        - limitsKey: "nvidia.com/gpu"
+          uiName: "NVIDIA"
+        - limitsKey: "amd.com/gpu"
+          uiName: "AMD"
 
       # the default value of the limit
       # (possible values: "none", "1", "2", "4", "8")
@@ -304,4 +303,4 @@ spawnerFormDefaults:
   ################################################################
   environment:
     readOnly: false
-    value: {}
+    value: {}
diff --git a/notebooks/crud-web-apps/jupyter/manifests/base/configs/spawner_ui_config.yaml b/notebooks/crud-web-apps/jupyter/manifests/base/configs/spawner_ui_config.yaml
@@ -129,12 +129,11 @@ spawnerFormDefaults:
       # the list of available vendors in the dropdown
       #  `limitsKey` - what will be set as the actual limit
       #  `uiName` - what will be displayed in the dropdown UI
-      vendors: []
-      #vendors:
-      #  - limitsKey: "nvidia.com/gpu"
-      #    uiName: "NVIDIA"
-      #  - limitsKey: "amd.com/gpu"
-      #    uiName: "AMD"
+      vendors:
+        - limitsKey: "nvidia.com/gpu"
+          uiName: "NVIDIA"
+        - limitsKey: "amd.com/gpu"
+          uiName: "AMD"
 
       # the default value of the limit
       # (possible values: "none", "1", "2", "4", "8")
@@ -304,4 +303,4 @@ spawnerFormDefaults:
   ################################################################
   environment:
     readOnly: false
-    value: {}
+    value: {}