Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barista logo svg #201

Merged
merged 2 commits into from Dec 22, 2017
Merged

Barista logo svg #201

merged 2 commits into from Dec 22, 2017

Conversation

EsteveAguilera
Copy link
Contributor

@EsteveAguilera EsteveAguilera commented Dec 21, 2017

This PR will fix #105 by using the SVG Barista logo.
Say bye-bye to the blurry logo! 馃暫

You can find a preview here:
https://github.com/EsteveAguilera/Barista/tree/barista-logo-svg

BTW, it seems that the SVG file I've used is not perfect, it has some square shadows :S

I think it will be great if someone can remove the extra padding on the SVG file, it adds a lot of useless white space on top and bottom of the image on the README

Copy link
Member

@SmasSive SmasSive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The improvement is noticeable, great work 馃憤

Copy link
Member

@Sloy Sloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! Thanks a lot @EsteveAguilera, I prefer a square shadow over the blurry logo. 馃憤

@Sloy Sloy merged commit 8fa3b44 into AdevintaSpain:master Dec 22, 2017
@rocboronat
Copy link
Member

鉂わ笍

@EsteveAguilera
Copy link
Contributor Author

I know you'll love it @rocboronat 馃槉

Btw, I just realized how bad is the message of this commit! Sorry 馃槶

@EsteveAguilera EsteveAguilera deleted the barista-logo-svg branch December 27, 2017 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Barista's icon using the .SVG provided by the lovely designer
5 participants