Implemented repeat attempts by default #394
Conversation
|
Hi! Wow, having a @repeat is great! Just one thing. What do the tests do? I don't get the names: Thanks @danieldisu! |
|
@rocboronat Both tests were doing the same, I removed one and change the name of the other for
I've extracted the Statement building to methods, but I'm not sure that's what you were pointing here 🤔 |
|
@Sloy @rocboronat @alorma Can you review it again 🙏 |
| * Use this method when constructing the Rule to apply a default behavior of @[Repeat] without having to add the annotation to | ||
| * each test. This can help you to find flaky tests. | ||
| * <br></br> | ||
| * The default behavior can be overridden with [Repeat] or [Repeat]. |
There was a problem hiding this comment.
It was [Repeat] or [AllowFlaky], fixed!
| @@ -44,6 +44,16 @@ public void repeatStatementReturnedWhenRepeatAnnotationFound() throws Exception | |||
| assertTrue(resultStatement instanceof RepeatStatement); | |||
| } | |||
|
|
|||
| @Test | |||
| public void repeatStatementReturnedWhenRepeatSetRepeatAttemptsByDefault() throws Exception { | |||
There was a problem hiding this comment.
Sorry, I don't get the repeat set repeat 😅
Maybe repeatStatementReturnedWhenSettingDefaultRepeatAttempts?
There was a problem hiding this comment.
Yep, it make sense 👍 , changed
| } | ||
|
|
||
| @Test | ||
| public void lastStatementReturnedWhenRepeatAttemptsByDefaultAndAllowFlakyStatementUsedAtTheSameTime() throws Exception { |
There was a problem hiding this comment.
Not that important because it's easier to get, but just to be coherent:
lastStatementReturnedWhenDefaultRepeatAttemptsAndAllowFlakyStatementUsedAtTheSameTime
|
There are some comments but if the Adevinta team wants to go on, it's good for me 👍 Thanks @danieldisu! |
|
Let's wait for the CI to finish testing... |
In this PR I've added a method that allows users to set repeat attempts by default, it works the same way than
allowFlakyAttemptsByDefaultbut applies the@Retryannotation to all methods