Migrate Geocoder to coroutines #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldisu
reviewed
Apr 8, 2022
| } catch (exception: IOException) { | ||
| emptyList() | ||
| } | ||
| override fun getFromLocationName(query: String): List<Address> { |
There was a problem hiding this comment.
geocoder.getFromLocationName(query, MAX_RESULTS) can block the thread? should getFromLocationName be a suspend fun?
There was a problem hiding this comment.
I'm not sure about this, I think It should not be a problem because is always called under a suspend fun. And I also think that has a time out exception that raises the IOException.
danieldisu
reviewed
Apr 8, 2022
| .build() | ||
| val results = geoDataClient.findAutocompletePredictions(findAutocompletePredictionsRequest) | ||
| try { | ||
| Tasks.await(results, PREDICTIONS_WAITING_TIME, TimeUnit.SECONDS) |
There was a problem hiding this comment.
What are you trying to achieve here?
There was a problem hiding this comment.
Here I only removed the Single.defer wrap. If I remember well this was a copy&paste from Google documentation.
🤔 Probably this must be reviewed later on.
jlquintana
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to migrate all the library from RxJava to Kotlin Coroutines we have migrated the GeocoderRepository to Coroutines.
Screenshots
No screens
Mandatory GIF