[NO ISSUE] Replaced deprecated onActivityResult method with the new activity result launcher #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranpons
requested review from
marcserrascmspain,
gerardpedreny and
jlquintana
ferranpons
changed the title
jlquintana
reviewed
Aug 30, 2022
Comment on lines
77
to
82
| lekuActivityResultLauncher = | ||
| registerForActivityResult(ActivityResultContracts.StartActivityForResult()) { result: ActivityResult -> | ||
| if (result.resultCode == Activity.RESULT_OK) { | ||
| onResult(result.resultCode, result.data) | ||
| } else { | ||
| Log.d("RESULT****", "CANCELLED") |
There was a problem hiding this comment.
ActivityResultLaunchers are usually initialized on the property definition, so you can avoid using late init var and use a val.
There was a problem hiding this comment.
You're absolutely right. Applied the changes. Many thanks!
jlquintana
approved these changes
Aug 30, 2022
delete-merged-branch
bot
deleted the
NO-ISSUE-replaced-old-onActivityResult
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
No Issue
Description
We have replaced the deprecated "startActivityForResult" method with the new activity result launcher.
Screenshots
No screens
Mandatory GIF