Added Auto-complete feature for the search view (related to issue #55) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranpons
requested review from
alorma,
CristianGM,
marcserrascmspain and
gerardpedreny
Closed
marcserrascmspain
approved these changes
Jan 31, 2017
alorma
reviewed
Jan 31, 2017
| public void showDebouncedLocations(List<Address> addresses) { | ||
| if (addresses != null) { | ||
| fillLocationList(addresses); | ||
| if (!addresses.isEmpty()) { |
There was a problem hiding this comment.
Maybe a method to filter addresses could be great (if anyone overrides activity)
There was a problem hiding this comment.
What you say sounds interesting but not in the scope of this PR. Please add an issue for that. Many thanks for the suggestion!
alorma
approved these changes
Jan 31, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the feature requested from issue #55