Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host Rules: support multiple IP addresses for one host #1381

Closed
szolin opened this issue Jan 30, 2020 · 2 comments
Closed

Host Rules: support multiple IP addresses for one host #1381

szolin opened this issue Jan 30, 2020 · 2 comments
Assignees
@ainar-g
Labels
enhancement external libs Issues that require changes in external libraries. P4: Low
Milestone
v0.107.0

Comments

@szolin
Copy link
Contributor

szolin commented Jan 30, 2020 

1.1.1.1 host
2.2.2.2 host

2 IP addresses match host - we should support this:

  • Respond with 2 A records
  • Add 2 rules and 2 filter IDs to query logs
  • UI should display multiple rules on query logs page
@szolin szolin added this to the v0.102 milestone Jan 30, 2020
@ameshkov ameshkov modified the milestones: v0.102, v0.104 Jan 30, 2020
@ainar-g ainar-g added the external libs Issues that require changes in external libraries. label Jun 3, 2021
@ainar-g ainar-g self-assigned this Jun 3, 2021
@ainar-g
Copy link
Contributor

ainar-g commented Jun 3, 2021

This is probably already done in the urlfilter module. I should check it and, if it's not implemented. implement it.

@ameshkov
Copy link
Member

ameshkov commented Jun 3, 2021

@ainar-g according to this, should be really easy to do that: AdguardTeam/urlfilter@59ecbb2

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: all: sup many ips in host rules
d3674ca 
Closes AdguardTeam#1381.

Squashed commit of the following:

commit 44965f7
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jun 17 13:54:44 2021 +0300

    dnsforward: imp code, docs

commit 23736cf
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Jun 16 20:33:59 2021 +0300

    dnsforward: rm todo

commit ff08675
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Jun 16 20:32:01 2021 +0300

    all: sup many ips in host rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
enhancement external libs Issues that require changes in external libraries. P4: Low
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
3 participants
@ainar-g @ameshkov @szolin