Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show more information for CNAME matches #1429

Closed
3 tasks done
hoshsadiq opened this issue Feb 24, 2020 · 2 comments
Closed
3 tasks done

show more information for CNAME matches #1429

hoshsadiq opened this issue Feb 24, 2020 · 2 comments

Comments

@hoshsadiq
Copy link

hoshsadiq commented Feb 24, 2020

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Problem Description

Since #1185 it has been possible to block domains that are disguised through CNAMEs. Currently when I see a blocked domain, I can see which list blocks that specific domain. This is also the case for domains matched through CNAME lists (the ones that show up as Blocked by CNAME or IP in response).

While the items that were blocked directly isn't an issue, as you can see in the block list the exact reason why it's blocked, for CNAME resolved matches it's not as straight forward. Specifically, all it shows is Blocked by CNAME or IP in response, the list that is blocking the domain, and lastly the answer's IPs. It's hard to figure out which item in the list blocked it.

Proposed Solution

It would be nice to say which exact domain in the list ended up blocking this request. E.g. if badguy.com is blocked, and the badguy.thirdparty.com is a CNAME to badguy.com, the message in the query list should show something like:

Domain name Type Response
badguy.thirdparty.com A Blocked by CNAME or IP in response
A: 8.8.8.8 (ttl=251)
Blocked because badguy.com was blocked

Alternatives Considered

N/A

Additional Information

N/A

@ghost
Copy link

ghost commented Feb 24, 2020

@hoshsadiq Hover mouse over (?) icon that display next to 'Blocked by CNAME or IP in response' then you can be see the matched rule. I dont know if that had changed after #993 however display exact rule better than the sentence.

@hoshsadiq
Copy link
Author

Aah pardon me. The ones I was getting confused about was blocked due to an IP address being in the blocklist. You're right, it is there! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant