Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to edit "DNS rewrites" IP entries #1577

Closed
jitdor opened this issue Apr 13, 2020 · 13 comments
Closed

Ability to edit "DNS rewrites" IP entries #1577

jitdor opened this issue Apr 13, 2020 · 13 comments

Comments

@jitdor
Copy link

jitdor commented Apr 13, 2020

I wanted to use Adguard Home's "DNS rewrites" function to redirect DNS requests to specific SNI proxies. However, once a rewrite rule is added, there is no easy way to edit it (which needs to happen when the SNI proxy IP changes). The only solution now is to remove all entries and re-enter them under DNS rewrites, or host an additional DNSmasq server serving those custom records and then specify it under the upstream DNS server in the [/domain-to-proxy.com/]ip_of_dnsmasq method.

It would be great if the rewrite rules' IP can be easily edited.

@Aikatsui
Copy link
Contributor

Duplicate of #1374

@ameshkov
Copy link
Member

@Archive5 let's keep this one as it got more upvotes

@ragnaroks
Copy link

ragnaroks commented Jul 8, 2020

i think "DNS block list" item can add a field ActionType,include Block/Rewrite


if the item is Block

||domain1.com^
||domain2.com^

they are both return the address in config like NXDOMAIN


if the item is Rewrite

@default 192.168.1.1
||domain1.com^
||domain2.com^=>192.168.12.34

*.domain1.com will return 192.168.1.1
*.domain2.com will return 192.168.12.34

@ragnaroks
Copy link

or no "ActionType",just try find => to decide "Block"/"Rewrite"

@ragnaroks
Copy link

snipaste_20200708_114920

@ameshkov
Copy link
Member

ameshkov commented Jul 8, 2020

But there's already "DNS rewrites", it seems natural to extend it, and not the blocklists.

@ZeroClover
Copy link

ZeroClover commented Sep 1, 2020

Maybe load DNS rewrite entries from files as Filter does? This will allow for better maintainability, especially when managing multiple AGH instances.

@ainar-g
Copy link
Contributor

ainar-g commented Jun 3, 2021

We'll probably ship this functionality together with the new API and UI redesign.

@gyCfjSnO
Copy link

gyCfjSnO commented Jun 4, 2021

Would love the ability to bulk import DNS Rewrites as I don't know how I am going to easily add 10K.

Only way at the moment is putting the list in the DNS Blocklist but it shows up as a block in the logs.

@jrickter88
Copy link

We really need the ability to edit the re-write dns entries we've made.

@fernvenue fernvenue mentioned this issue Apr 3, 2022
3 tasks
@jffz
Copy link

jffz commented Jul 6, 2022

I see that this was planned for 0.104.0, is there any news about this feature ?

@jrickter88
Copy link

anything? please?

@jschwalbe
Copy link

When a server goes down it's frustrating to have to delete/readd all the rewrites (especially if only temporary). Is there a workaround somehow?

adguard pushed a commit that referenced this issue Jun 23, 2023
Updates #1577

Squashed commit of the following:

commit a07ff51
Merge: 7db6968 2f515e8
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Jun 23 16:50:09 2023 +0300

    Merge branch 'master' into AG-22207

commit 7db6968
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Jun 23 14:57:09 2023 +0300

    fix changelog

commit bf9458b
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Jun 23 14:48:20 2023 +0300

    changelog

commit bc2bf3f
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Jun 23 13:28:28 2023 +0300

    client: handle rewrite edit
@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.33 Jul 3, 2023
@ainar-g ainar-g closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests