Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHCP clients purge options #1691

Closed
danselstory opened this issue May 17, 2020 · 11 comments
Closed

DHCP clients purge options #1691

danselstory opened this issue May 17, 2020 · 11 comments
Assignees
@ainar-g
Labels
enhancement P3: Medium
Milestone
v0.107.0

Comments

@danselstory
Copy link

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • [-] I am running the latest version
  • [-] I checked the documentation and found no answer
  • [-] I checked to make sure that this issue has not already been filed

Problem Description

I noticed that the DHCP setting don't page "purge" clients option. This means invalidate all IP addresses and require client to request new ip. It will be good if we have it.

Also looks like if the clients HOSTNAME change, the DHCP servers in Adguard still "cache" old hostname.

Proposed Solution

Ability to purge all DHCP clients data so it clear the hostname, require clients to reconnect and we will get the new hostname properly.

Alternatives Considered

Additional Information
@ameshkov ameshkov added this to the v0.103 milestone May 18, 2020
@ameshkov ameshkov modified the milestones: v0.103, v0.104 May 18, 2020
@danselstory
Copy link
Author

thanks a lot team AdGuard Home !!

@szolin szolin removed their assignment Aug 18, 2020
@ainar-g ainar-g self-assigned this Jun 3, 2021
adguard pushed a commit that referenced this issue Jun 16, 2021
@ainar-g
Pull request: dhcpd: add purge, imp code
84e71e9 
Updates #1691.

Squashed commit of the following:

commit 2ce6cc0
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Jun 16 16:42:57 2021 +0300

    dhcp: imp code

commit 8f2bd70
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Jun 16 16:27:06 2021 +0300

    dhcpd: add purge, imp code
adguard pushed a commit that referenced this issue Jun 17, 2021
@ainar-g
Pull request: client: add reset leases btn
5104b79 
Updates #1691.

Squashed commit of the following:

commit 2c48fb9
Merge: 38f5191 7547d3a
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jun 17 14:28:23 2021 +0300

    Merge branch 'master' into 1691-dhcp-reset-form

commit 38f5191
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Jun 17 13:14:59 2021 +0300

    client: handle dhcp leases reset

commit a97df17
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Jun 16 17:12:10 2021 +0300

    client: add reset leases btn
@ainar-g
Copy link
Contributor

ainar-g commented Jun 17, 2021

@danselstory, sorry for the long waiting time. We have added the “Reset all leases” button to the DHCP settings, and you can try it out on the edge channel in revision 5104b79. Could you please check if this feature works for you? Thanks!

@danselstory
Copy link
Author

danselstory commented Jun 17, 2021 via email

@ainar-g
Copy link
Contributor

ainar-g commented Jun 21, 2021

@danselstory, were you able to test the feature? I'm thinking of closing this issue, since most of our tests show that it works well.

@danselstory
Copy link
Author

danselstory commented Jun 21, 2021 via email

@ainar-g
Copy link
Contributor

ainar-g commented Jun 21, 2021

Thanks for testing!

Yes, it should first appear in v0.107.0-b3, which should be released at the end of June, and then in the final v0.107.0 release in the middle of July.

@ainar-g ainar-g closed this as completed Jun 21, 2021
@ten24bytes
Copy link

The reset all leases also clears the saved list of static leases. Can we just renew all the leases without resetting the saved static DHCP list?
I had setup 10-12 static leases and all of them got cleared, which was so painful to setup all over again.

@ten24bytes
Copy link

The reset all leases also clears the saved list of static leases. Can we just renew all the leases without resetting the saved static DHCP list?
I had setup 10-12 static leases and all of them got cleared, which was so painful to setup all over again. There should also be an option to copy a lease from the existing leases directly into the static leases just like we have in PiHole. That is so intuitive and user-friendly.

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: dhcpd: add purge, imp code
84859d2 
Updates AdguardTeam#1691.

Squashed commit of the following:

commit 2ce6cc0
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Jun 16 16:42:57 2021 +0300

    dhcp: imp code

commit 8f2bd70
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Jun 16 16:27:06 2021 +0300

    dhcpd: add purge, imp code
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: client: add reset leases btn
1b78135 
Updates AdguardTeam#1691.

Squashed commit of the following:

commit 2c48fb9
Merge: 38f5191 7547d3a
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jun 17 14:28:23 2021 +0300

    Merge branch 'master' into 1691-dhcp-reset-form

commit 38f5191
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Jun 17 13:14:59 2021 +0300

    client: handle dhcp leases reset

commit a97df17
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Jun 16 17:12:10 2021 +0300

    client: add reset leases btn
@stefanmd023
Copy link

The reset all leases also clears the saved list of static leases. Can we just renew all the leases without resetting the saved static DHCP list? I had setup 10-12 static leases and all of them got cleared, which was so painful to setup all over again. There should also be an option to copy a lease from the existing leases directly into the static leases just like we have in PiHole. That is so intuitive and user-friendly.

Has this been fixed yes? I have 4 pages worth of static leases I don't want to lose them all, I ONLY want to release the dynamic ones which I do not need.

@stefanmd023
Copy link

The reset all leases also clears the saved list of static leases. Can we just renew all the leases without resetting the saved static DHCP list? I had setup 10-12 static leases and all of them got cleared, which was so painful to setup all over again. There should also be an option to copy a lease from the existing leases directly into the static leases just like we have in PiHole. That is so intuitive and user-friendly.

In the end I removed the dynamic leases in this way:

  1. stop adguardhome service
  2. take backup of data/leases.json
  3. edit data/leases.json to remove the entries, search for "static=false"
  4. start adguardhome service

dynamic leases gone

@ainar-g
Copy link
Contributor

ainar-g commented Dec 4, 2023

@ten24bytes, @stefanmd023, please file a new feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
enhancement P3: Medium
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
6 participants
@ten24bytes @ainar-g @ameshkov @danselstory @szolin @stefanmd023