Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastest IP address Related configuration #1992

Closed
wysnxzm opened this issue Aug 4, 2020 · 8 comments
Closed

Fastest IP address Related configuration #1992

wysnxzm opened this issue Aug 4, 2020 · 8 comments
Assignees
@EugeneOne1
Labels
enhancement P4: Low
Milestone
v0.107.0

Comments

@wysnxzm
Copy link

wysnxzm commented Aug 4, 2020

Provide dns response timeout settings and ip response timeout settings, the current timeout seems to be 10 seconds
@wysnxzm wysnxzm changed the title Fastest IP address Fastest IP address Related configuration Aug 4, 2020
@ameshkov ameshkov modified the milestones: v1.0, v0.106 Aug 4, 2020
@lordraiden
Copy link

Considering that the timeout is 10 seconds and it looks like an easy fix shouldn't this be addressed earlier?

@wysnxzm
Copy link
Author

wysnxzm commented Aug 6, 2020

Considering that the timeout is 10 seconds and it looks like an easy fix shouldn't this be addressed earlier?

I think the DNS timeout should be within 200ms
IP response timeout is within 600ms
However, you also need to consider the worst case, that is, all DNS timeouts and IP timeouts. At this time, you should choose an IP with a relatively fast response. This may exceed the set timeout period.

@ainar-g ainar-g added P4: Low and removed P3: Medium labels Jun 3, 2021
@ainar-g ainar-g mentioned this issue Aug 12, 2021
Closed
adguard pushed a commit to AdguardTeam/dnsproxy that referenced this issue Aug 27, 2021
@EugeneOne1
Pull request: 1992 conf timeouts
27e9036 
Merge in DNS/dnsproxy from 1992-conf-timeouts to master

Updates AdguardTeam/AdGuardHome#1992.

Squashed commit of the following:

commit 454e883
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Aug 27 16:19:48 2021 +0300

    fastip: fix type

commit 1a9d035
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Aug 27 16:18:20 2021 +0300

    fastip: fix doc

commit 745fb15
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Aug 27 16:11:37 2021 +0300

    fastip: imp code, docs

commit aa4b777
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Aug 27 12:37:13 2021 +0300

    fastip: imp quality a bit

commit bbd9640
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Aug 25 19:30:57 2021 +0300

    fastip: mk ping timeout configurable
adguard pushed a commit to AdguardTeam/dnsproxy that referenced this issue Aug 27, 2021
@EugeneOne1
Pull request: Export default ping timeout
24059f4 
Merge in DNS/dnsproxy from exp-const to master

Updates AdguardTeam/AdGuardHome#1992.

Squashed commit of the following:

commit 65aa4bf
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Aug 27 19:32:50 2021 +0300

    fastip: export the default ping timeout
adguard pushed a commit that referenced this issue Aug 27, 2021
@EugeneOne1
Pull request: 1992 configurable timeouts
e064e0f 
Merge in DNS/adguard-home from 1992-conf-timeouts to master

Updates #1992.

Squashed commit of the following:

commit 1050c54
Merge: 05f71c3 5954416
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Aug 27 20:04:25 2021 +0300

    Merge branch 'master' into 1992-conf-timeouts

commit 05f71c3
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Aug 27 20:03:06 2021 +0300

    home: use const

commit d086179
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Aug 27 19:16:26 2021 +0300

    home: fix default timeout

commit ba26fcd
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Aug 27 16:50:33 2021 +0300

    all: mk ping timeout configurable
@EugeneOne1
Copy link
Member

@wysnxzm, the latest edge build should provide the desired functionality. It's described in wiki. In brief, AdGuardHome.yaml configuration file now has the new FastestTimeout setting. It defines the timeout for pinging the resolved addresses, so that pinging process won't take more than it.
The timeout for used upstreams, however, is already configurable with the upstream_timeout setting.

@wysnxzm
Copy link
Author

wysnxzm commented Aug 28, 2021

@wysnxzm, the latest edge build should provide the desired functionality. It's described in wiki. In brief, AdGuardHome.yaml configuration file now has the new FastestTimeout setting. It defines the timeout for pinging the resolved addresses, so that pinging process won't take more than it.
The timeout for used upstreams, however, is already configurable with the upstream_timeout setting.

Thank you. Love you

@EugeneOne1
Copy link
Member

@wysnxzm, would you like to test it before closing the issue?

@wysnxzm
Copy link
Author

wysnxzm commented Aug 30, 2021

@wysnxzm, would you like to test it before closing the issue?

no problem

@EugeneOne1
Copy link
Member

@wysnxzm, any updates since? Can we close the issue?

@wysnxzm
Copy link
Author

wysnxzm commented Sep 2, 2021

@wysnxzm, any updates since? Can we close the issue?

Very good. I don't see any problems

@wysnxzm wysnxzm closed this as completed Sep 2, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 1992 configurable timeouts
246ef36 
Merge in DNS/adguard-home from 1992-conf-timeouts to master

Updates AdguardTeam#1992.

Squashed commit of the following:

commit 1050c54
Merge: 05f71c3 5954416
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Aug 27 20:04:25 2021 +0300

    Merge branch 'master' into 1992-conf-timeouts

commit 05f71c3
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Aug 27 20:03:06 2021 +0300

    home: use const

commit d086179
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Aug 27 19:16:26 2021 +0300

    home: fix default timeout

commit ba26fcd
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Aug 27 16:50:33 2021 +0300

    all: mk ping timeout configurable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
enhancement P4: Low
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
6 participants
@ainar-g @ameshkov @wysnxzm @lordraiden @EugeneOne1 @szolin