Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable statistics the same way it is possible to disable protocols #2141

Closed
halest opened this issue Sep 30, 2020 · 3 comments
Closed

Disable statistics the same way it is possible to disable protocols #2141

halest opened this issue Sep 30, 2020 · 3 comments
Assignees
@ainar-g
Labels
enhancement P3: Medium
Milestone
v0.107.0

Comments

@halest
Copy link

halest commented Sep 30, 2020

Problem Description

On HomeAssistant I moved from PiHole to AdGuard and was suprised it doesn't have the option to switch to an "anonymous mode" like it was possible there. While it is possible to disable protocols, most of the critical information still shows up in the statistics without an option to turn it off. I do not want to know or see what my clients are doing. That is none of my business.

Proposed Solution

Add a "disable statistics" button, analog to the "disable protocols" button.

Alternatives Considered

Create an "anonymous mode" that doesn't keep any data.

Additional Information

Using HomeAssistant-Plugin
@ameshkov ameshkov added this to the v0.107 milestone Oct 1, 2020
This was referenced May 17, 2021
Closed
Open
@ainar-g ainar-g self-assigned this Jun 3, 2021
adguard pushed a commit that referenced this issue Jun 17, 2021
@ainar-g
Pull request: all: make stats disableable, imp code
dbe8b92 
Updates #2141.

Squashed commit of the following:

commit d8f3bcd
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jun 17 19:10:53 2021 +0300

    stats: imp docs, names

commit 97eae3c
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jun 17 18:51:49 2021 +0300

    all: make stats disableable, imp code
@ainar-g
Copy link
Contributor

ainar-g commented Jun 17, 2021

This is implemented as of edge snapshot dbe8b92. Can you please check if our implementation works for you?

@halest
Copy link
Author

halest commented Jun 17, 2021

Thanks @ainar-g ! I'm currently running the Homeassistant-Plugin so I can't easily do that but I did instead proofread the changes in the commit and it looks good to me. Smart and simple solution :)

@ainar-g
Copy link
Contributor

ainar-g commented Jun 18, 2021

I see, thanks! The feature seems to work in our tests, so I'll close this issue for now.

@ainar-g ainar-g closed this as completed Jun 18, 2021
@ainar-g ainar-g mentioned this issue Jul 5, 2021
Closed
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: all: make stats disableable, imp code
f0d97a6 
Updates AdguardTeam#2141.

Squashed commit of the following:

commit d8f3bcd
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jun 17 19:10:53 2021 +0300

    stats: imp docs, names

commit 97eae3c
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jun 17 18:51:49 2021 +0300

    all: make stats disableable, imp code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
enhancement P3: Medium
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
3 participants
@ainar-g @ameshkov @halest