Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The log does not search in files when there're too many buffered query log items #2325

Closed
ameshkov opened this issue Nov 17, 2020 · 0 comments
Closed

The log does not search in files when there're too many buffered query log items #2325

ameshkov opened this issue Nov 17, 2020 · 0 comments
Assignees
@ainar-g
Labels
bug P2: High
Milestone
v0.104.2

Comments

@ameshkov
Copy link
Member

Steps to reproduce:

  1. Run AdGuard Home
  2. Make sure that there're records in querylog.json
  3. Run nslookup example.org 127.0.0.1 a few dozen times
  4. Open the "query log" page and scroll it down

Expected result

All query log items are loaded including the ones from the querylog.jso

Actual result

Only items from the in-memory buffer are displayed
@ameshkov ameshkov added this to the v0.104.2 milestone Nov 17, 2020
adguard pushed a commit that referenced this issue Dec 10, 2020
@ainar-g @Blakhard
Pull request: querylog: use better error signaling
62dc6c0 
Merge in DNS/adguard-home from 2325-querylog-suffering to master

Closes #2325.

Squashed commit of the following:

commit 9038805
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Nov 19 12:37:00 2020 +0300

    all: changelog

commit bbdeabb
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Nov 19 12:33:21 2020 +0300

    querylog: improve error reporting

commit 807b23a
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Nov 18 19:39:22 2020 +0300

    querylog: improve docs

commit 65a8f4f
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Nov 18 19:36:28 2020 +0300

    querylog: use better error signaling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P2: High
Projects
None yet
Milestone
v0.104.2
Development

No branches or pull requests
2 participants
@ainar-g @ameshkov