Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve --version output #2416

Closed
ainar-g opened this issue Dec 11, 2020 · 0 comments
Closed

Improve --version output #2416

ainar-g opened this issue Dec 11, 2020 · 0 comments
Assignees
@EugeneOne1
Labels
enhancement P4: Low
Milestone
v0.106.0

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Dec 11, 2020

Our current AdGuardHome --version output looks something like this:

AdGuard Home, version v0.105.0-SNAPSHOT-ef178610, channel edge, arch linux amd64

A few things are lacking:

  1. Go compiler version.
  2. Go module version.
  3. Dependencies' versions.
  4. If --race is enabled.
  5. MIPS CPU options.
  6. Date of build.

Compare that to Dominik Honnef's staticcheck --debug.version output:

$ staticcheck --debug.version
staticcheck (devel, v0.0.1-2020.1.0.20201208010337-0767310fbbbb)

Compiled with Go version: go1.15.6
Main module:
	honnef.co/go/tools@v0.0.1-2020.1.0.20201208010337-0767310fbbbb (sum: h1:V3EAIQEywp37Bj+RAaZ1gOyE8PObBTjZaFS5q1phXIA=)
Dependencies:
	github.com/BurntSushi/toml@v0.3.1 (sum: h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=)
	golang.org/x/mod@v0.4.0 (sum: h1:8pl+sMODzuvGJkmj2W4kZihvVb5mKm8pB/X44PIQHv8=)
	golang.org/x/tools@v0.0.0-20201208233053-a543418bbed2 (sum: h1:vEtypaVub6UvKkiXZ2xx9QIvp9TL7sI7xp7vdi2kezA=)
	golang.org/x/xerrors@v0.0.0-20200804184101-5ec99f83aff1 (sum: h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=)

I think we should add more information to our output. Perhaps, only show it when both -v and --version are set?
@ainar-g ainar-g added this to the v0.106.0 milestone Dec 11, 2020
adguard pushed a commit that referenced this issue Mar 31, 2021
@EugeneOne1
Pull request: 2416 improve version output
1d07afb 
Merge in DNS/adguard-home from 2416-version to master

Updates #2416.

Squashed commit of the following:

commit ad529ee
Merge: 9ba2f68 bfc7e16
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Mar 31 12:42:37 2021 +0300

    Merge branch 'master' into 2416-version

commit 9ba2f68
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Mar 31 12:40:53 2021 +0300

    all: fix docs

commit 521a61d
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 30 17:48:56 2021 +0300

    all: imp code

commit 844c4e0
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 30 17:48:56 2021 +0300

    all: imp docs, log changes

commit c8206b0
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 30 17:19:51 2021 +0300

    version: imp verbose output

commit b2b41d4
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 30 16:37:23 2021 +0300

    version: imp code, docs

commit 553bd9c
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 30 14:07:05 2021 +0300

    version: imp verbosed output
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2416 improve version output
4f18c7c 
Merge in DNS/adguard-home from 2416-version to master

Updates AdguardTeam#2416.

Squashed commit of the following:

commit ad529ee
Merge: 9ba2f68 bfc7e16
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Mar 31 12:42:37 2021 +0300

    Merge branch 'master' into 2416-version

commit 9ba2f68
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Mar 31 12:40:53 2021 +0300

    all: fix docs

commit 521a61d
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 30 17:48:56 2021 +0300

    all: imp code

commit 844c4e0
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 30 17:48:56 2021 +0300

    all: imp docs, log changes

commit c8206b0
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 30 17:19:51 2021 +0300

    version: imp verbose output

commit b2b41d4
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 30 16:37:23 2021 +0300

    version: imp code, docs

commit 553bd9c
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 30 14:07:05 2021 +0300

    version: imp verbosed output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
enhancement P4: Low
Projects
None yet
Milestone
v0.106.0
Development

No branches or pull requests
2 participants
@ainar-g @EugeneOne1