Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"DNS cache configuration" does not accept any "Override minimum TTL" value #2459

Closed
uservictor opened this issue Dec 20, 2020 · 2 comments
Closed

"DNS cache configuration" does not accept any "Override minimum TTL" value #2459

uservictor opened this issue Dec 20, 2020 · 2 comments
Assignees
@EugeneOne1
Labels
bug P3: Medium
Milestone
v0.105.0

Comments

@uservictor
Copy link

uservictor commented Dec 20, 2020 •
edited
Loading

Hello I am using AdGuardHome 0.105.0-beta.1

Raspberry Pi 4B
Raspberry OS Lite (December 2nd 2020)
Linux raspberrypi 5.4.79-v8+ aarch64
AdGuardHome_linux_armv6.tar.gz

There is a Bug on DNS cache configuration. The UI does not accept any value in Override minimum TTL!
I just can set the Override maximum TTL value and to apply changes .

If I put a value to min TTL then I can not apply changes and I get this error massage:

Error: control/dns_config | cache_ttl_min must be less or equal than cache_ttl_max | 400

To reproduce, I used this values:
Cache value : 8388608
Min TTL : 14400
Max TTL : 172800

Have a nice weekend
@ameshkov ameshkov added this to the v0.105.0 milestone Dec 21, 2020
@ameshkov ameshkov removed this from the v0.105.0 milestone Dec 21, 2020
@ainar-g ainar-g assigned EugeneOne1 and unassigned ainar-g Dec 21, 2020
@ainar-g ainar-g added this to the v0.105.0 milestone Dec 21, 2020
adguard pushed a commit that referenced this issue Dec 21, 2020
@EugeneOne1
Pull request: fix dns cache ttl check
f165fd9 
Merge in DNS/adguard-home from 2459-dns-ttl to master

Updates #2459.

Squashed commit of the following:

commit 27e74e3
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon Dec 21 15:00:46 2020 +0300

    all: log changes

commit e476fa5
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon Dec 21 14:55:30 2020 +0300

    dnsforward: fix dns cache ttl check
@EugeneOne1
Copy link
Member

This should be fixed as of snapshot bdff46e. Could you please check if our solution fixes the issue for you?

@uservictor
Copy link
Author

It works properly on v0.105.0-SNAPSHOT-bdff46ec
thanks

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: fix dns cache ttl check
918a5b2 
Merge in DNS/adguard-home from 2459-dns-ttl to master

Updates AdguardTeam#2459.

Squashed commit of the following:

commit 27e74e3
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon Dec 21 15:00:46 2020 +0300

    all: log changes

commit e476fa5
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon Dec 21 14:55:30 2020 +0300

    dnsforward: fix dns cache ttl check
@ardel ardel mentioned this issue Nov 10, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.105.0
Development

No branches or pull requests
4 participants
@ainar-g @ameshkov @EugeneOne1 @uservictor